chenjunjiedada commented on code in PR #5195:
URL: https://github.com/apache/iceberg/pull/5195#discussion_r917884758
##########
data/src/main/java/org/apache/iceberg/data/DeleteFilter.java:
##########
@@ -192,13 +196,10 @@ protected void markRowDeleted(T item) {
}
public Predicate<T> eqDeletedRowFilter() {
- if (eqDeleteRows == null) {
Review Comment:
I just found out that we don't use this function right now. How about
directly using the original function like this:
``` java
private CloseableIterable<T> applyEqDeletes(CloseableIterable<T> records) {
Filter<T> remainingRowsFilter = new Filter<T>() {
@Override
protected boolean shouldKeep(T item) {
return eqDeletedRowFilter().test(item);
}
};
return remainingRowsFilter.filter(records);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
