rdblue commented on code in PR #5195:
URL: https://github.com/apache/iceberg/pull/5195#discussion_r918490842
##########
data/src/main/java/org/apache/iceberg/data/DeleteFilter.java:
##########
@@ -70,7 +70,7 @@
private final int isDeletedColumnPosition;
private PositionDeleteIndex deleteRowPositions = null;
- private Predicate<T> eqDeleteRows = null;
Review Comment:
I don't see a need to remove this. Can you add it back?
##########
data/src/main/java/org/apache/iceberg/data/DeleteFilter.java:
##########
@@ -132,8 +132,12 @@ public CloseableIterable<T> filter(CloseableIterable<T>
records) {
}
private List<Predicate<T>> applyEqDeletes() {
+ if (eqDeletePredicates != null) {
+ return eqDeletePredicates;
+ }
Review Comment:
Please add an empty newline after this block to follow style guidelines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
