rdblue commented on code in PR #5195:
URL: https://github.com/apache/iceberg/pull/5195#discussion_r918492578
##########
data/src/main/java/org/apache/iceberg/data/DeleteFilter.java:
##########
@@ -132,8 +132,12 @@ public CloseableIterable<T> filter(CloseableIterable<T>
records) {
}
private List<Predicate<T>> applyEqDeletes() {
+ if (eqDeletePredicates != null) {
+ return eqDeletePredicates;
+ }
List<Predicate<T>> isInDeleteSets = Lists.newArrayList();
if (eqDeletes.isEmpty()) {
+ this.eqDeletePredicates = isInDeleteSets;
Review Comment:
I think a better solution is to make `isInDeleteSets` a private field in
place of `eqDeletePredicates`. You should just rename the new
`eqDeletePredicates` field to `isInDeleteSets` and set it on the line above
instead of creating a local variable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
