rdblue commented on code in PR #5120:
URL: https://github.com/apache/iceberg/pull/5120#discussion_r918432647
##########
flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/FlinkCatalog.java:
##########
@@ -619,12 +630,17 @@ public void alterPartition(ObjectPath tablePath,
CatalogPartitionSpec partitionS
@Override
public List<String> listFunctions(String dbName) throws CatalogException {
- return Collections.emptyList();
+ return Lists.newArrayList(partitionFunctions.keySet());
Review Comment:
I'm not sure whether Flink allows you to omit the database name or not, but
that's up to Flink. Iceberg should not expose these functions as though they
exist in all databases, though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
