danielcweeks commented on code in PR #5289:
URL: https://github.com/apache/iceberg/pull/5289#discussion_r923938835
##########
aws/src/test/java/org/apache/iceberg/aws/s3/TestS3FileIO.java:
##########
@@ -218,8 +219,7 @@ public void testPrefixList() {
public void testPrefixDelete() {
String prefix = "s3://bucket/path/to/delete";
List<Integer> scaleSizes = Lists.newArrayList(0, 5, 1000, 2500);
-
- scaleSizes.parallelStream().forEach(scale -> {
+ scaleSizes.forEach(scale -> {
Review Comment:
The original rational for using the parallel stream was to help speedup the
tests because it take the S3 mock library a considerable amount of time to
create 2.5K files (even all locally). The intent of the scale factors was to
ensure that pagination in the s3 list calls is working correctly. If these
tests are run in parallel with the other project tests, I think it's probably
fine to just call sequentially.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
