amogh-jahagirdar commented on code in PR #5289:
URL: https://github.com/apache/iceberg/pull/5289#discussion_r924087183
##########
aws/src/test/java/org/apache/iceberg/aws/s3/TestS3FileIO.java:
##########
@@ -218,8 +219,7 @@ public void testPrefixList() {
public void testPrefixDelete() {
String prefix = "s3://bucket/path/to/delete";
List<Integer> scaleSizes = Lists.newArrayList(0, 5, 1000, 2500);
-
- scaleSizes.parallelStream().forEach(scale -> {
+ scaleSizes.forEach(scale -> {
Review Comment:
Makes sense, the pagination is handled by the AWS SDK listObjectsV2Paginator
so effectively that's already unit tested through the AWS SDK. Integ tests can
validate the actual behavior and we can do a parallel delete as you mentioned.
Updated and ran integ tests, which are passing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
