amogh-jahagirdar commented on code in PR #5289:
URL: https://github.com/apache/iceberg/pull/5289#discussion_r923958262
##########
aws/src/test/java/org/apache/iceberg/aws/s3/TestS3FileIO.java:
##########
@@ -218,8 +219,7 @@ public void testPrefixList() {
public void testPrefixDelete() {
String prefix = "s3://bucket/path/to/delete";
List<Integer> scaleSizes = Lists.newArrayList(0, 5, 1000, 2500);
-
- scaleSizes.parallelStream().forEach(scale -> {
+ scaleSizes.forEach(scale -> {
Review Comment:
Yeah it makes sense to parallelize because S3 mock still takes a lot of time
in the high scale case. The unit tests are run concurrently, so I think we're
good there.
Since the issue seems to lie with S3 mock, I think to truly validate this
behavior it makes sense to have integ tests which validate against S3 but for
now I think it makes sense to just address the unit tests. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
