samredai commented on code in PR #5303:
URL: https://github.com/apache/iceberg/pull/5303#discussion_r925413163
##########
python/pyiceberg/expressions/base.py:
##########
@@ -327,30 +328,26 @@ def bind(self, schema: Schema, case_sensitive: bool) ->
BoundIn[T]:
return BoundIn(bound_ref, tuple(lit.to(bound_ref.field.field_type) for
lit in self.literals)) # type: ignore
-class BooleanExpressionVisitor(Generic[T], ABC):
Review Comment:
Ok updated to revert this back to an ABC class. Since
`BoundBooleanExpressionVisitor` is also an ABC class, the abstractmethods are
just carried forward. I'll keep in mind the `NotImplementedError` option as we
add concrete implementations. 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
