rdblue commented on code in PR #5303:
URL: https://github.com/apache/iceberg/pull/5303#discussion_r926800328
##########
python/pyiceberg/expressions/base.py:
##########
@@ -431,7 +431,13 @@ def _(obj: And, visitor: BooleanExpressionVisitor[T]) -> T:
@visit.register(In)
def _(obj: In, visitor: BooleanExpressionVisitor[T]) -> T:
"""Visit an In boolean expression with a concrete
BooleanExpressionVisitor"""
- return visitor.visit_unbound_predicate(predicate=obj)
+ return visitor.visit_unbound_predicate(obj)
+
+
[email protected](BoundIn)
+def _(obj: BoundIn, visitor: BooleanExpressionVisitor[T]) -> T:
Review Comment:
I don't think this should be registered for the regular expression visitor,
just the bound visitor. The regular visitor should always call
`visit_bound_predicate` for all bound predicates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
