dramaticlly commented on code in PR #5373:
URL: https://github.com/apache/iceberg/pull/5373#discussion_r934823675
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/actions/DeleteOrphanFilesSparkAction.java:
##########
@@ -161,6 +163,12 @@ public DeleteOrphanFilesSparkAction olderThan(long
newOlderThanTimestamp) {
return this;
}
+ @Override
+ public DeleteOrphanFilesSparkAction batchSize(int batchSize) {
Review Comment:
You probably want to use `Preconditions` to validate and throw
`IllegalArgumentException ` for invalid batch size such as 0 or negative number
based on the javadoc in
`api/src/main/java/org/apache/iceberg/actions/DeleteOrphanFiles.java` interface
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
