amogh-jahagirdar commented on PR #5373: URL: https://github.com/apache/iceberg/pull/5373#issuecomment-1201713531
I've updated this PR to be based off my change here: https://github.com/apache/iceberg/pull/5379/files That change should go in first and then this PR can just focus on the integration with the procedure. In the updated logic for the procedure, we will always use the delete func if it's specified. If a delete function is not specified and the file io does not support bulk operations we would use the default delete function. Otherwise the bulk delete is used by default. What this means is bulk operations will always be used without considering user input. I was discussing with @dramaticlly perhaps we want more control over this and it should be specified in the action (something like useBulkDelete())? Also now we are delegating task management to the file IO, which I think makes sense but there's another argument that each procedure should control this since failure handling or retries. What are peoples thoughts here? @dramaticlly @aokolnychyi @RussellSpitzer @karuppayya -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
