amogh-jahagirdar commented on PR #5373: URL: https://github.com/apache/iceberg/pull/5373#issuecomment-1201969319
> but we throw an exception if they want a customized delete function AND bulk. I'm not sure about throwing an exception if a user specify delete function and if the file io supports bulk delete is the way to go, because then we're changing the behavior of the exposed deleteFunc API. I think if deleteFunc is set, the procedure continues to use that as a source of truth regardless of bulk delete support or not. So that would mean user's code would need to get rewritten if it's using S3FileIO and running this procedure with custom delete. We are changing the behavior if they do not specify a delete func and if it supports bulk delete, but the behavior changes internally how the procedure runs and is not really exposed to a user. Let me know what you think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
