RussellSpitzer commented on code in PR #5409:
URL: https://github.com/apache/iceberg/pull/5409#discussion_r934925616
##########
api/src/main/java/org/apache/iceberg/UpdateSchema.java:
##########
@@ -410,4 +410,18 @@ default UpdateSchema updateColumn(String name,
Type.PrimitiveType newType, Strin
default UpdateSchema setIdentifierFields(String... names) {
return setIdentifierFields(Sets.newHashSet(names));
}
+
+ /**
+ * Determines if the case of schema needs to be considered when updating
schema
+ *
+ * @param caseSensitive when false, the case of fields in schema is ignored
+ * @return this for method chaining
+ * @throws IllegalStateException If it encounters errors during provided
schema traversal
+ * @throws IllegalArgumentException If name doesn't identify a column in the
schema or if this
+ * change introduces a type incompatibility or if it conflicts with
other additions, renames,
+ * or updates.
+ */
+ default UpdateSchema caseSensitive(boolean caseSensitive) {
+ throw new UnsupportedOperationException();
Review Comment:
Ok one issue here, We only apply the implementation of "caseSensitive" to
unionXXX but I think it also applies to
```
updateColumn
updateColumnDoc
makeColumnOptional
requireColumn
deleteColumn
moveFirst
moveBefore (2x here)
moveAfter (2x here as well)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
