RussellSpitzer commented on code in PR #5409:
URL: https://github.com/apache/iceberg/pull/5409#discussion_r935785246
##########
api/src/main/java/org/apache/iceberg/UpdateSchema.java:
##########
@@ -410,4 +410,18 @@ default UpdateSchema updateColumn(String name,
Type.PrimitiveType newType, Strin
default UpdateSchema setIdentifierFields(String... names) {
return setIdentifierFields(Sets.newHashSet(names));
}
+
+ /**
+ * Determines if the case of schema needs to be considered when updating
schema
+ *
+ * @param caseSensitive when false, the case of fields in schema is ignored
+ * @return this for method chaining
+ * @throws IllegalStateException If it encounters errors during provided
schema traversal
Review Comment:
Basically I think this doc can just be
```java
/**
* Determines if the case of schema needs to be considered when comparing
column names
*
* @param caseSensitive when false case is not considered when comparing
column names.
* @return this for method chaining
**/
```
##########
api/src/main/java/org/apache/iceberg/UpdateSchema.java:
##########
@@ -410,4 +410,18 @@ default UpdateSchema updateColumn(String name,
Type.PrimitiveType newType, Strin
default UpdateSchema setIdentifierFields(String... names) {
return setIdentifierFields(Sets.newHashSet(names));
}
+
+ /**
+ * Determines if the case of schema needs to be considered when updating
schema
+ *
+ * @param caseSensitive when false, the case of fields in schema is ignored
+ * @return this for method chaining
+ * @throws IllegalStateException If it encounters errors during provided
schema traversal
Review Comment:
Even that's a bit duplicative ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
