RussellSpitzer commented on code in PR #5409:
URL: https://github.com/apache/iceberg/pull/5409#discussion_r935800167
##########
core/src/main/java/org/apache/iceberg/SchemaUpdate.java:
##########
@@ -128,7 +129,7 @@ private void internalAddColumn(
int parentId = TABLE_ROOT_ID;
String fullName;
if (parent != null) {
- Types.NestedField parentField = schema.findField(parent);
+ Types.NestedField parentField = findField(parent);
Preconditions.checkArgument(parentField != null, "Cannot find parent
struct: %s", parent);
Review Comment:
minor note here, we may want to add in a hint about case sensitivity.
`Cannot find parent struct: %s , case-sensitive: %b`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
