RussellSpitzer commented on code in PR #5409:
URL: https://github.com/apache/iceberg/pull/5409#discussion_r936930866
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/SparkWriteConf.java:
##########
@@ -297,4 +297,13 @@ public IsolationLevel isolationLevel() {
confParser.stringConf().option(SparkWriteOptions.ISOLATION_LEVEL).parseOptional();
return isolationLevelName != null ?
IsolationLevel.fromName(isolationLevelName) : null;
}
+
+ public boolean caseSensitive() {
+ return confParser
+ .booleanConf()
+ .sessionConf(SparkSQLProperties.CASE_SENSITIVE)
+ .option(SparkWriteOptions.CASE_SENSITIVE)
+ .defaultValue(true)
Review Comment:
This should probably always match the Spark default as well, which is
"false". I can't remember if Spark will always populate this key in the config,
but we definitely want to align with Spark's default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
