RussellSpitzer commented on code in PR #5409:
URL: https://github.com/apache/iceberg/pull/5409#discussion_r936928690


##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/SparkWriteOptions.java:
##########
@@ -77,4 +77,7 @@ private SparkWriteOptions() {}
 
   // Isolation Level for DataFrame calls. Currently supported by 
overwritePartitions
   public static final String ISOLATION_LEVEL = "isolation-level";
+
+  // Checks if case of schema needs to be considered during

Review Comment:
   I think here it only applies during "mergeSchema or if allowAnySchema" is in 
use. I'm also not sure if we want to expose this here, User's should just be 
using Spark's case-sensitive property. I don't think we want them changing it 
for individual operations from the session default. 
   
   I think we are probably better off just dropping this as an option



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to