rdblue commented on code in PR #5150:
URL: https://github.com/apache/iceberg/pull/5150#discussion_r939702492
##########
spark/v3.1/spark/src/main/java/org/apache/iceberg/spark/SparkReadOptions.java:
##########
@@ -35,6 +35,9 @@ private SparkReadOptions() {}
// A timestamp in milliseconds; the snapshot used will be the snapshot
current at this time.
public static final String AS_OF_TIMESTAMP = "as-of-timestamp";
+ // Snapshot Ref of the table snapshot to read from
+ public static final String SNAPSHOT_REF = "snapshot-ref";
Review Comment:
Since this is user-facing, it should be two properties, `branch` and `tag`
##########
spark/v3.1/spark/src/main/java/org/apache/iceberg/spark/source/SparkBatchQueryScan.java:
##########
@@ -61,22 +62,32 @@ class SparkBatchQueryScan extends SparkBatchScan {
this.snapshotId = readConf.snapshotId();
this.asOfTimestamp = readConf.asOfTimestamp();
+ this.snapshotRef = readConf.snapshotRef();
+
Review Comment:
Style: unnecessary whitespace.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
