rdblue commented on code in PR #5150:
URL: https://github.com/apache/iceberg/pull/5150#discussion_r939702574
##########
spark/v3.1/spark/src/main/java/org/apache/iceberg/spark/source/SparkBatchQueryScan.java:
##########
@@ -61,22 +62,32 @@ class SparkBatchQueryScan extends SparkBatchScan {
this.snapshotId = readConf.snapshotId();
this.asOfTimestamp = readConf.asOfTimestamp();
+ this.snapshotRef = readConf.snapshotRef();
+
if (snapshotId != null && asOfTimestamp != null) {
throw new IllegalArgumentException(
"Cannot scan using both snapshot-id and as-of-timestamp to select
the table snapshot");
+ } else if (snapshotId != null && snapshotRef != null) {
+ throw new IllegalArgumentException(
+ "Cannot scan using both snapshot-id and snapshot-ref to select the
table snapshot");
+ } else if(asOfTimestamp!= null && snapshotRef != null) {
+ throw new IllegalArgumentException(
+ "Cannot scan using both as-of-timestamp and snapshot-ref to select
the table snapshot");
Review Comment:
This is possible. I also think we should probably let the core context
handle throwing exceptions, rather than checking here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
