rdblue commented on code in PR #5150:
URL: https://github.com/apache/iceberg/pull/5150#discussion_r940835880
##########
api/src/main/java/org/apache/iceberg/TableScan.java:
##########
@@ -49,6 +49,16 @@ public interface TableScan extends Scan<TableScan,
FileScanTask, CombinedScanTas
*/
TableScan asOfTime(long timestampMillis);
+ /**
+ * Create a new {@link TableScan} from this scan's configuration that will
use the most recent
+ * snapshot as of the given snapshot ref.
+ *
+ * @param snapshotRef a snapshot Ref
+ * @return a new scan based on this with the given snapshot Ref
+ * @throws IllegalArgumentException if the snapshot cannot be found
+ */
+ TableScan useSnapshotRef(String snapshotRef);
Review Comment:
Yeah, I considered that as well. The problem is that the caller doesn't know
whether the ref is a tag or a branch before calling the method. That's
determined when we look at table metadata and we don't want to force the caller
to do that.
There may be a better name than "ref" for `useRef`. That seems like the
problem to me. Maybe we could simplify it to `use`? I'm not sure that's obvious
enough.
@aokolnychyi, do you have any thoughts on the name here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
