Fokko commented on code in PR #5488:
URL: https://github.com/apache/iceberg/pull/5488#discussion_r947184644
##########
python/pyiceberg/catalog/__init__.py:
##########
@@ -53,7 +54,15 @@ class Catalog(ABC):
def __init__(self, name: str | None, **properties: str):
self.name = name
- self.properties = properties
+
+ if name is not None:
Review Comment:
GlueCatalog wouldn't have a URI, but let's not overcomplicate things. I made
it mandatory.
I also removed `PYICEBERG_URI` I think it is better and less confusing in
the long run to have on the way of setting the environment variables. I also
refactored the properties, mostly by changing all the `__init__` methods of the
catalogs:
```python
def __init__(
self,
name: str,
**properties: str,
):
```
This way we don't have any specifics in the Catalog itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
