Fokko commented on code in PR #5488:
URL: https://github.com/apache/iceberg/pull/5488#discussion_r947187195
##########
python/pyiceberg/catalog/__init__.py:
##########
@@ -53,7 +54,15 @@ class Catalog(ABC):
def __init__(self, name: str | None, **properties: str):
self.name = name
- self.properties = properties
+
+ if name is not None:
+ configuration = Config().get_catalog_config(name)
Review Comment:
Great suggestion, just implemented that. I left the `py-impl` out of scope;
this PR is already getting far too big.
While we're at it. One question, do we keep the `FileIO` at a catalog level?
You could also specify it on a table level `create_table(...,
properties={'py-impl': 'pyarrow'}` right? I was browsing the Java codebase, and
it looks that's it is at a catalog level (which would make things easier).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
