Fokko commented on code in PR #5488:
URL: https://github.com/apache/iceberg/pull/5488#discussion_r947039673
##########
python/pyiceberg/catalog/__init__.py:
##########
@@ -53,7 +54,15 @@ class Catalog(ABC):
def __init__(self, name: str | None, **properties: str):
self.name = name
- self.properties = properties
+
+ if name is not None:
Review Comment:
In the first instance, I would a name to be mandatory. I changed this
because of the configuration. If you don't have a name, it won't load the
config environment variable `PYICEBERG_CATALOG__DEFAULT__URI`, and fall back to
`PYICEBERG_URI` in the CLI. I can imagine that we want to change this, but I'm
not fully settled on this one either.
What I don't really like is that the `PYICEBERG_URI` and
`PYICEBERG_CREDENTIAL` are REST specific, and I wouldn't like to open a door to
having another way of setting config for other catalog implementations in the
future (for Glue PYICEBERG_AWS_ACCOUNT_ID for example).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
