stevenzwu commented on code in PR #5601:
URL: https://github.com/apache/iceberg/pull/5601#discussion_r952968013
##########
api/src/main/java/org/apache/iceberg/transforms/Bucket.java:
##########
@@ -79,8 +77,16 @@ public Integer numBuckets() {
return numBuckets;
}
- @VisibleForTesting
- abstract int hash(T value);
+ @Override
+ @SuppressWarnings("unchecked")
+ public Function<T, Integer> bind(Type type) {
+ return (Function<T, Integer>) get(type, numBuckets);
+ }
+
+ protected int hash(T value) {
Review Comment:
why do we change this from an abstract method to a method with default impl
that throws an exceptoin?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
