stevenzwu commented on code in PR #5601:
URL: https://github.com/apache/iceberg/pull/5601#discussion_r952982599
##########
api/src/main/java/org/apache/iceberg/transforms/Bucket.java:
##########
@@ -90,6 +96,11 @@ public Integer apply(T value) {
return (hash(value) & Integer.MAX_VALUE) % numBuckets;
}
+ @Override
+ public boolean canTransform(Type type) {
+ return type.isPrimitiveType();
Review Comment:
is this correct? If we can `canTransform(StringType)` on `BucketLong`, this
will pass. Or caller always use the same `type` as the bucket type and this is
not a concern?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
