stevenzwu commented on code in PR #5601:
URL: https://github.com/apache/iceberg/pull/5601#discussion_r952966133
##########
api/src/main/java/org/apache/iceberg/transforms/Bucket.java:
##########
@@ -114,6 +125,7 @@ public String toString() {
@Override
public UnboundPredicate<Integer> project(String name, BoundPredicate<T>
predicate) {
+ Function<T, Integer> apply = this.bind(predicate.term().type());
Review Comment:
nit: should we call this `function`? then we can avoid the `apply.apply`
later in line 137, which looks a little weird.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
