JonasJ-ap commented on code in PR #5644:
URL: https://github.com/apache/iceberg/pull/5644#discussion_r956634548
##########
aws/src/main/java/org/apache/iceberg/aws/AwsClientFactories.java:
##########
@@ -105,6 +106,7 @@ public S3Client s3() {
return S3Client.builder()
.httpClientBuilder(configureHttpClientBuilder(httpClientType))
.applyMutation(builder -> configureEndpoint(builder, s3Endpoint))
+ .dualstackEnabled(s3DualStackEnabled)
Review Comment:
Of course. Here is what I found:
According to the description in:
https://sdk.amazonaws.com/java/api/latest/software/amazon/awssdk/services/s3/S3Configuration.Builder.html
The `dualstackEnabled()` function for S3Configuration builder is now
deprecated. So I think we should use the one for all AWS clients instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
