JonasJ-ap commented on code in PR #5644:
URL: https://github.com/apache/iceberg/pull/5644#discussion_r957643555
##########
aws/src/main/java/org/apache/iceberg/aws/AwsClientFactories.java:
##########
@@ -97,6 +97,7 @@ static class DefaultAwsClientFactory implements
AwsClientFactory {
private Boolean s3AccelerationEnabled;
private String dynamoDbEndpoint;
private String httpClientType;
+ private Boolean s3DualStackEnabled;
Review Comment:
Thank you for your review and suggestions!
Here is what I was thinking when writing `line 100`:
1. The method `dualStackEnabled(Boolean dualstackEndpointEnabled)` specified
its argument type as a boxed boolean. The doc I refer to:
https://sdk.amazonaws.com/java/api/latest/software/amazon/awssdk/awscore/client/builder/AwsClientBuilder.html
2. Other similar flags like `s3AccelerationEnabled`,
`s3UseArnRegionEnabled`, and `s3PathStyleAccess` use boxed boolean.
Hence, I think it may be a good idea to keep this pattern and use `Boolean`
as the type for `s3DualStackEnabled`.
I also tried the primitive type version of `s3DualStackEnabled`. It turns
out that the Autoboxing works well and the code compiles and passes
`iceberg-aws` test. So it seems the boxed type here is not a strict requirement
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
