jackye1995 commented on code in PR #5644:
URL: https://github.com/apache/iceberg/pull/5644#discussion_r956637459
##########
aws/src/main/java/org/apache/iceberg/aws/AwsClientFactories.java:
##########
@@ -105,6 +106,7 @@ public S3Client s3() {
return S3Client.builder()
.httpClientBuilder(configureHttpClientBuilder(httpClientType))
.applyMutation(builder -> configureEndpoint(builder, s3Endpoint))
+ .dualstackEnabled(s3DualStackEnabled)
Review Comment:
Ah I see. That makes sense. In that case I think this PR should be "AWS:
support dual stack for AWS clients", and we introduce flag
`client.dualstack-enabled` for all AWS clients.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
