nastra commented on code in PR #5696:
URL: https://github.com/apache/iceberg/pull/5696#discussion_r962982424
##########
aws/src/test/java/org/apache/iceberg/aws/s3/TestS3FileIO.java:
##########
@@ -250,6 +261,53 @@ public void testPrefixDelete() {
});
}
+ @Test
+ public void testReadMissingLocation() {
+ String location = "s3://bucket/path/to/data.parquet";
+ InputFile in = s3FileIO.newInputFile(location);
+ AssertHelpers.assertThrows(
Review Comment:
nit: I know we use `AssertHelpers.assertThrows` everywhere in the codebase.
Most of the times the error msg that is being provided to `assertThrows` isn't
really useful. `Assertions.assertThatThrownBy(...)` is cleaner and more
expressive imo and I wonder whether we should promote this for new test code
being added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
