rdblue commented on code in PR #5696:
URL: https://github.com/apache/iceberg/pull/5696#discussion_r963044833
##########
aws/src/test/java/org/apache/iceberg/aws/s3/TestS3FileIO.java:
##########
@@ -250,6 +261,53 @@ public void testPrefixDelete() {
});
}
+ @Test
+ public void testReadMissingLocation() {
+ String location = "s3://bucket/path/to/data.parquet";
+ InputFile in = s3FileIO.newInputFile(location);
+ AssertHelpers.assertThrows(
Review Comment:
I like the version that encourages people to check the error message. The
issue I have with `assertThatThrownBy` is that it's really easy for people to
leave out validations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
