nastra commented on code in PR #5696:
URL: https://github.com/apache/iceberg/pull/5696#discussion_r963050608
##########
aws/src/test/java/org/apache/iceberg/aws/s3/TestS3FileIO.java:
##########
@@ -250,6 +261,53 @@ public void testPrefixDelete() {
});
}
+ @Test
+ public void testReadMissingLocation() {
+ String location = "s3://bucket/path/to/data.parquet";
+ InputFile in = s3FileIO.newInputFile(location);
+ AssertHelpers.assertThrows(
Review Comment:
that is true, that's why imo `assertThatThrownBy()` + `isInstanceOf()` +
`hasMessage()` should always be used together, but that isn't easily enforced
(unless we maybe add a version of `AssertHelpers.assertThrows` without a
message that describes the assertion check).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
