JonasJ-ap commented on code in PR #5684:
URL: https://github.com/apache/iceberg/pull/5684#discussion_r962342819
##########
aws/src/main/java/org/apache/iceberg/aws/AssumeRoleAwsClientFactory.java:
##########
@@ -121,7 +112,7 @@ protected <T extends AwsClientBuilder &
AwsSyncClientBuilder> T configure(T clie
.build());
clientBuilder.region(Region.of(region));
-
clientBuilder.httpClientBuilder(AwsClientFactories.configureHttpClientBuilder(httpClientType));
+ awsProperties.applyHttpClientConfiguration(clientBuilder);
Review Comment:
Would it be better if we just created the `AssumeRoleRequest` upfront while
still keeping this `configure` method? Since the four aws clients need some
common configuration in the `AssumeRole` case, the `configure` method may help
us reduce duplicated codes above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
