JiJiTang commented on code in PR #5539:
URL: https://github.com/apache/iceberg/pull/5539#discussion_r967416409
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##########
@@ -210,6 +232,11 @@ protected String tableName() {
return fullName;
}
+ @Override
+ protected EncryptionManagerFactory encryptionManagerFactory() {
Review Comment:
@rdblue, very good spot, thanks VM! During my first iteration, I was putting
this method in `TableOperations` and use the factory to return the manager, and
this will make `TableOperations` have two encryption related methods, some of
my colleagues were worrying about breaking change to `TableOperations` as
public API. Myself I vote also to move this method to `TableOperations` cc
@stevenzwu @ggershinsky for inputs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
