JiJiTang commented on code in PR #5539:
URL: https://github.com/apache/iceberg/pull/5539#discussion_r975739639
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##########
@@ -210,6 +232,11 @@ protected String tableName() {
return fullName;
}
+ @Override
+ protected EncryptionManagerFactory encryptionManagerFactory() {
Review Comment:
@rdblue , calling encryptionManagerFactory.create() will be a duplicated
logic for table operations sub classes. That's why I put the duplicated logic
to `BaseMetastoreTableOperations` class and in that class I defined method
`protected abstract EncryptionManagerFactory encryptionManagerFactory()`. I
would think the factory create logic to `TableOperations` directly and that
would require to make `TableOperations` as an abstract class, need your advice
on this.
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##########
@@ -210,6 +232,11 @@ protected String tableName() {
return fullName;
}
+ @Override
+ protected EncryptionManagerFactory encryptionManagerFactory() {
Review Comment:
@rdblue , calling encryptionManagerFactory.create() will be duplicated logic
for table operations sub classes. That's why I put the duplicated logic to
`BaseMetastoreTableOperations` class and in that class I defined method
`protected abstract EncryptionManagerFactory encryptionManagerFactory()`. I
would think the factory create logic to `TableOperations` directly and that
would require to make `TableOperations` as an abstract class, need your advice
on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
