JiJiTang commented on code in PR #5539:
URL: https://github.com/apache/iceberg/pull/5539#discussion_r967440824


##########
core/src/main/java/org/apache/iceberg/hadoop/HadoopTables.java:
##########
@@ -203,13 +204,31 @@ public boolean dropTable(String location, boolean purge) {
     }
   }
 
+  private Map<String, String> encryptionConfigFromConf() {

Review Comment:
   @rdblue , not sure I understand this one, need your help to clarify: do you 
mean for `HadoopTables` we don't need to incorporate `EncryptionManagerFactory` 
initialisation logic or we shouldn't load the catalog properties from Hadoop 
conf?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to