sririshindra commented on code in PR #5622:
URL: https://github.com/apache/iceberg/pull/5622#discussion_r971478721
##########
api/src/main/java/org/apache/iceberg/actions/ActionsProvider.java:
##########
@@ -31,6 +31,11 @@ default SnapshotTable snapshotTable(String sourceTableIdent)
{
/** Instantiates an action to migrate an existing table to Iceberg. */
default MigrateTable migrateTable(String tableIdent) {
+ return migrateTable(tableIdent, false);
+ }
+
+ /** Instantiates an action to migrate an existing table to Iceberg. */
+ default MigrateTable migrateTable(String tableIdent, Boolean dropBackup) {
Review Comment:
Done, Fixed in the latest commit.
##########
spark/v3.0/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestMigrateTableProcedure.java:
##########
@@ -84,7 +84,7 @@ public void testMigrateWithOptions() throws IOException {
sql("INSERT INTO TABLE %s VALUES (1, 'a')", tableName);
Object result =
- scalarSql("CALL %s.system.migrate('%s', map('foo', 'bar'))",
catalogName, tableName);
+ scalarSql("CALL %s.system.migrate('%s', false, map('foo', 'bar'))",
catalogName, tableName);
Review Comment:
Fixed in the latest commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
