sririshindra commented on code in PR #5622:
URL: https://github.com/apache/iceberg/pull/5622#discussion_r978900121


##########
spark/v3.0/spark/src/main/java/org/apache/iceberg/spark/actions/BaseMigrateTableSparkAction.java:
##########
@@ -112,6 +112,8 @@ private MigrateTable.Result doExecute() {
     StagedSparkTable stagedTable = null;
     Table icebergTable;
     boolean threw = true;
+    boolean dropBackup =
+        Boolean.parseBoolean(additionalProperties().getOrDefault("dropBackup", 
"false"));

Review Comment:
   I added the extra dropBackup method on MigrateTableSparkAction as you 
suggested in the latest commit. This way we avoid modifying the table 
properties. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to