sririshindra commented on code in PR #5622:
URL: https://github.com/apache/iceberg/pull/5622#discussion_r981913671
##########
spark/v3.0/spark/src/main/java/org/apache/iceberg/spark/actions/BaseMigrateTableSparkAction.java:
##########
@@ -221,4 +230,12 @@ private void restoreSourceTable() {
e);
}
}
+
+ private void dropBackupTable() {
+ try {
+ destCatalog().dropTable(backupIdent);
+ } catch (Exception e) {
+ LOG.error("Cannot drop the backup table {} after migrate is completed.",
backupIdent, e);
Review Comment:
I am not sure I understand the grammar error here, but I think it matches
the style of the rest of the error messages in the file. But I changed `after
migrate ` to `after migration`.
##########
api/src/main/java/org/apache/iceberg/actions/MigrateTable.java:
##########
@@ -41,6 +41,14 @@ public interface MigrateTable extends Action<MigrateTable,
MigrateTable.Result>
*/
MigrateTable tableProperty(String name, String value);
+ /**
+ * Sets the dropBackup property to drop backup table after a successful
table Migration
+ *
+ * @param dropBackup flag to remove backup table
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
