findepi commented on PR #5774: URL: https://github.com/apache/iceberg/pull/5774#issuecomment-1263352085
> The intent here was to refer to the function defined for the `int` type. I know. This PR isn't fixing anything, as nothing was wrong. It only tries to avoid potentially confusing wording. > t looks like people are confusing these functions with hash specific methods in the hash implementation. Indeed. > this change makes the spec less specific because it removes the long(value) cast that is required for int and makes it implicit. Not sure where you see this. Is it in `hashLong(daysFromUnixEpoch(v))`? The `daysFromUnixEpoch` it a hypothetic function, not defined anywhere, so a reader can just assume it returns a long number, if that's what `hashLong` expects. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
