findepi commented on PR #5774: URL: https://github.com/apache/iceberg/pull/5774#issuecomment-1263891363
> Since `hashInt` is also a hypothetical function, it's okay to use it. it's also a name of `org.apache.iceberg.relocated.com.google.common.hash.HashFunction#hashInt` available on the `Hashing.murmur3_32_fixed` object. > daysFromUnixEpoch is represented in most places as an int ``` iceberg master$ git grep daysFromUnixEpoch format/spec.md:| **`date`** | `hashInt(daysFromUnixEpoch(v))` | `2017-11-16` ￫ `-653330422` | ``` > I think the fix is to name the functions in the spec as they are defined to make it clear that we're referring back to them. i am not sure i am following. can you please exemplify? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
