rdblue commented on PR #5774: URL: https://github.com/apache/iceberg/pull/5774#issuecomment-1263783052
`daysFromUnixEpoch` is represented in most places as an int and I didn't want any confusion over how it should be represented. An int is perfectly fine. Since `hashInt` is also a hypothetical function, it's okay to use it. I think the fix is to name the functions in the spec as they are defined to make it clear that we're referring back to them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
