Fokko commented on code in PR #5845:
URL: https://github.com/apache/iceberg/pull/5845#discussion_r993823074
##########
python/pyiceberg/expressions/base.py:
##########
@@ -867,3 +877,205 @@ def visit_unbound_predicate(self, predicate) ->
BooleanExpression:
def visit_bound_predicate(self, predicate) -> BooleanExpression:
return predicate
+
+
+ROWS_MIGHT_MATCH = True
+ROWS_CANNOT_MATCH = False
+IN_PREDICATE_LIMIT = 200
+
+
+def _from_byte_buffer(field_type: IcebergType, val: bytes):
+ if not isinstance(field_type, PrimitiveType):
+ raise ValueError(f"Expected a PrimitiveType, got: {type(field_type)}")
+ return from_bytes(field_type, val)
+
+
+class _ManifestEvalVisitor(BoundBooleanExpressionVisitor[bool]):
+ partition_fields: list[PartitionFieldSummary]
+ partition_filter: BooleanExpression
+
+ def __init__(self, partition_struct_schema: Schema, partition_filter:
UnboundPredicate, case_sensitive: bool = True):
+ bound_partition_filter =
partition_filter.bind(partition_struct_schema, case_sensitive)
Review Comment:
Ah I see, I've updated the code 👍🏻
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
