rdblue commented on code in PR #5845:
URL: https://github.com/apache/iceberg/pull/5845#discussion_r993976843
##########
python/pyiceberg/expressions/base.py:
##########
@@ -654,17 +664,37 @@ def _(obj: Or, visitor: BooleanExpressionVisitor[T]) -> T:
return visitor.visit_or(left_result=left_result, right_result=right_result)
+def bind(schema: Schema, expression: BooleanExpression, case_sensitive: bool)
-> BooleanExpression:
Review Comment:
Minor: we usually add a default for `case_sensitive`. I think it's a good
idea to require it for internal methods, but this will probably be called from
many different places so I'd default it here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
