Fokko commented on code in PR #5845:
URL: https://github.com/apache/iceberg/pull/5845#discussion_r989955442
##########
python/pyiceberg/expressions/base.py:
##########
@@ -867,3 +875,196 @@ def visit_unbound_predicate(self, predicate) ->
BooleanExpression:
def visit_bound_predicate(self, predicate) -> BooleanExpression:
return predicate
+
+
+ROWS_MIGHT_MATCH = True
+ROWS_CANNOT_MATCH = False
+IN_PREDICATE_LIMIT = 200
+
+
+def _from_byte_buffer(field_type: IcebergType, val: bytes):
+ if not isinstance(field_type, PrimitiveType):
+ raise ValueError(f"Expected a PrimitiveType, got: {type(field_type)}")
+ return from_bytes(field_type, val)
+
+
+class ManifestEvaluator(BoundBooleanExpressionVisitor[bool]):
Review Comment:
Yes, I went a bit back and forth on this. I don't like having a setter that
sets something internal (`partition_fields`). I now created a function that
returns a Callable, that hides the visitor:
```python
def manifest_evaluator(
schema: Schema, partition_filter: UnboundPredicate, case_sensitive: bool
= True
) -> Callable[[ManifestFile], bool]:
evaluator = _ManifestEvalVisitor(schema, partition_filter,
case_sensitive)
return evaluator.eval
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
