rdblue commented on code in PR #6002:
URL: https://github.com/apache/iceberg/pull/6002#discussion_r1002764862
##########
core/src/test/java/org/apache/iceberg/TestFastAppend.java:
##########
@@ -114,12 +114,14 @@ public void testEmptyTableAppendFilesAndManifest() throws
IOException {
validateManifest(
snap.allManifests(FILE_IO).get(0),
- seqs(1, 1),
+ seqs(1L, 1L), // data sequence numbers
Review Comment:
Minor: I'd create two methods, `dataSeqs` and `fileSeqs` for this. That way
the code is self-documenting. We do basically the same thing for `ids` and
`seqs` currently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
