aokolnychyi commented on code in PR #6002:
URL: https://github.com/apache/iceberg/pull/6002#discussion_r1006111825
##########
core/src/test/java/org/apache/iceberg/TableTestBase.java:
##########
@@ -519,6 +534,12 @@ void validateManifest(
entry.sequenceNumber().longValue());
}
}
+ if (fileSeqs != null) {
+ V1Assert.assertEquals(
+ "File sequence number should default to 0", (Long) 0L,
entry.fileSequenceNumber());
+ V2Assert.assertEquals(
+ "File sequence number should match", fileSeqs.next(),
entry.fileSequenceNumber());
+ }
Review Comment:
I agree but it is not how this entire block is formatted. None of the other
if statements are separated by empty lines. I decided to follow the existing
formatting for consistency even though I'd surround each independent block by
empty lines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
