rdblue commented on code in PR #6002:
URL: https://github.com/apache/iceberg/pull/6002#discussion_r1002765756
##########
core/src/main/java/org/apache/iceberg/ManifestWriter.java:
##########
@@ -166,20 +189,21 @@ public void delete(F deletedFile) {
/**
* Add a delete entry for a file.
*
- * <p>The entry's snapshot ID will be this manifest's snapshot ID. However,
the original data
- * sequence number of the file must be preserved when the file is marked as
deleted.
+ * <p>The entry's snapshot ID will be this manifest's snapshot ID. However,
the original data and
+ * file sequence numbers of the file must be preserved when the file is
marked as deleted.
*
* @param deletedFile a file
* @param dataSequenceNumber a data sequence number of the file (assigned
when the file was added)
+ * @param fileSequenceNumber a file sequence number (assigned when the file
was added)
*/
- public void delete(F deletedFile, long dataSequenceNumber) {
- addEntry(reused.wrapDelete(snapshotId, dataSequenceNumber, deletedFile));
+ public void delete(F deletedFile, long dataSequenceNumber, Long
fileSequenceNumber) {
Review Comment:
It doesn't look like any of these delete methods are used, besides
`delete(ManifestEntry)`. Do we need to introduce this new method or can we
update the deprecation for `delete(ContentFile)` to point people to
`delete(ManifestEntry)`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
