rdblue commented on code in PR #6525:
URL: https://github.com/apache/iceberg/pull/6525#discussion_r1064184745
##########
python/pyiceberg/typedef.py:
##########
@@ -72,34 +71,9 @@ class StructProtocol(Protocol): # pragma: no cover
"""A generic protocol used by accessors to get and set at positions of an
object"""
@abstractmethod
- def get(self, pos: int) -> Any:
+ def __getitem__(self, pos: int) -> Any:
...
@abstractmethod
- def set(self, pos: int, value: Any) -> None:
+ def __setitem__(self, pos: int, value: Any) -> None:
...
-
-
-class Record(StructProtocol):
Review Comment:
I think it makes sense to put everything into `typedef`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
