rdblue commented on code in PR #6525:
URL: https://github.com/apache/iceberg/pull/6525#discussion_r1067543958
##########
python/pyiceberg/avro/reader.py:
##########
@@ -252,30 +252,33 @@ def skip(self, decoder: BinaryDecoder) -> None:
class StructReader(Reader):
field_readers: Tuple[Tuple[Optional[int], Reader], ...]
create_struct: Type[StructProtocol]
- fields: Optional[Tuple[NestedField, ...]]
+ struct: Optional[StructType]
def __init__(
self,
field_readers: Tuple[Tuple[Optional[int], Reader], ...],
create_struct: Optional[Type[StructProtocol]] = None,
- fields: Optional[Tuple[NestedField, ...]] = None,
+ struct: Optional[StructType] = None,
):
self.field_readers = field_readers
self.create_struct = create_struct or Record
- self.fields = fields
+ self.struct = struct
def read(self, decoder: BinaryDecoder) -> Any:
- if issubclass(self.create_struct, Record):
- struct = self.create_struct(length=len(self.field_readers),
fields=self.fields)
- elif issubclass(self.create_struct, PydanticStruct):
+ if issubclass(self.create_struct, PydanticStruct):
struct = self.create_struct.construct()
else:
- raise ValueError(f"Expected a subclass of PydanticStruct, got:
{self.create_struct}")
+ struct = self.create_struct()
+
+ if not isinstance(struct, StructProtocol):
+ raise ValueError(f"Expected struct to implement StructProtocol:
{struct}")
+
+ if self.struct:
+ struct.set_record_schema(self.struct)
Review Comment:
Do we want to do an `isinstance` check here eventually?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
